Requesting Code Review

1---
2name: requesting-code-review
3description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements
4---
5 
6# Requesting Code Review
7 
8Dispatch superpowers:code-reviewer subagent to catch issues before they cascade.
9 
10**Core principle:** Review early, review often.
11 
12## When to Request Review
13 
14**Mandatory:**
15- After each task in subagent-driven development
16- After completing major feature
17- Before merge to main
18 
19**Optional but valuable:**
20- When stuck (fresh perspective)
21- Before refactoring (baseline check)
22- After fixing complex bug
23 
24## How to Request
25 
26**1. Get git SHAs:**
27```bash
28BASE_SHA=$(git rev-parse HEAD~1)  # or origin/main
29HEAD_SHA=$(git rev-parse HEAD)
30```
31 
32**2. Dispatch code-reviewer subagent:**
33 
34Use Task tool with superpowers:code-reviewer type, fill template at `code-reviewer.md`
35 
36**Placeholders:**
37- `{WHAT_WAS_IMPLEMENTED}` - What you just built
38- `{PLAN_OR_REQUIREMENTS}` - What it should do
39- `{BASE_SHA}` - Starting commit
40- `{HEAD_SHA}` - Ending commit
41- `{DESCRIPTION}` - Brief summary
42 
43**3. Act on feedback:**
44- Fix Critical issues immediately
45- Fix Important issues before proceeding
46- Note Minor issues for later
47- Push back if reviewer is wrong (with reasoning)
48 
49## Example
50 
51```
52[Just completed Task 2: Add verification function]
53 
54You: Let me request code review before proceeding.
55 
56BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
57HEAD_SHA=$(git rev-parse HEAD)
58 
59[Dispatch superpowers:code-reviewer subagent]
60  WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
61  PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
62  BASE_SHA: a7981ec
63  HEAD_SHA: 3df7661
64  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
65 
66[Subagent returns]:
67  Strengths: Clean architecture, real tests
68  Issues:
69    Important: Missing progress indicators
70    Minor: Magic number (100) for reporting interval
71  Assessment: Ready to proceed
72 
73You: [Fix progress indicators]
74[Continue to Task 3]
75```
76 
77## Integration with Workflows
78 
79**Subagent-Driven Development:**
80- Review after EACH task
81- Catch issues before they compound
82- Fix before moving to next task
83 
84**Executing Plans:**
85- Review after each batch (3 tasks)
86- Get feedback, apply, continue
87 
88**Ad-Hoc Development:**
89- Review before merge
90- Review when stuck
91 
92## Red Flags
93 
94**Never:**
95- Skip review because "it's simple"
96- Ignore Critical issues
97- Proceed with unfixed Important issues
98- Argue with valid technical feedback
99 
100**If reviewer wrong:**
101- Push back with technical reasoning
102- Show code/tests that prove it works
103- Request clarification
104 
105See template at: requesting-code-review/code-reviewer.md
106